Skip to content

Commit

Permalink
Update CrashCollection to return the crash metric app version (#2046)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/0/1205599209825567/f
Tech Design URL:
CC:

Description:

This PR updates the app to use the correct crash app version. See BSK PR here: duckduckgo/BrowserServicesKit#515
  • Loading branch information
samsymons authored Sep 28, 2023
1 parent e60ac12 commit 76db01b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -8944,7 +8944,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 80.3.0;
version = 80.4.0;
};
};
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"repositoryURL": "https://github.com/DuckDuckGo/BrowserServicesKit",
"state": {
"branch": null,
"revision": "2bed3ed259ca7bde33f3d41424345acfeff8031d",
"version": "80.3.0"
"revision": "8192bc4708c36fda09667f1e84c2e29d3a725c0c",
"version": "80.4.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
Configuration.setURLProvider(AppConfigurationURLProvider())

CrashCollection.start {
Pixel.fire(pixel: .dbCrashDetected, withAdditionalParameters: $0, includedParameters: [.appVersion])
Pixel.fire(pixel: .dbCrashDetected, withAdditionalParameters: $0, includedParameters: [])
}

clearTmp()
Expand Down

0 comments on commit 76db01b

Please sign in to comment.