Skip to content

Commit

Permalink
Don't set up intro message when toggling internal feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
dus7 committed Aug 2, 2024
1 parent a5a3440 commit 1efccd0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 0 additions & 3 deletions DuckDuckGo/NewTabPageManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ final class NewTabPageManager: NewTabPageManaging, NewTabPageDebugging {
}
set {
appDefaults.newTabPageSectionsEnabled = newValue
if newValue {
NewTabPageIntroMessageSetup().perform(ignoringPublicAvailabilityCheck: true)
}
}
}

Expand Down
5 changes: 3 additions & 2 deletions DuckDuckGo/NewTabPageSectionsDebugView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ struct NewTabPageSectionsDebugView: View {
} header: {
Text(verbatim: "Feature settings")
} footer: {
Text(verbatim: "Requires internal user flag set to have an effect.\n\nEnabling the local flag will cause existing-user behavior for feature Intro Message.")
Text(verbatim: "Requires internal user flag set to have an effect.")
}

Section {
Expand Down Expand Up @@ -133,8 +133,9 @@ struct NewTabPageSectionsDebugView: View {
introMessageCountBinding.wrappedValue = 0
})

Button("Reset intro message setting", action: {
Button("Reset intro message", action: {
appSettings.newTabPageIntroMessageEnabled = nil
introMessageCountBinding.wrappedValue = 0
isIntroMessageInitialized = false
})
} header: {
Expand Down

0 comments on commit 1efccd0

Please sign in to comment.