Skip to content

Malicious site protection App settings #9801

Malicious site protection App settings

Malicious site protection App settings #9801

Triggered via pull request December 17, 2024 14:27
Status Failure
Total duration 12m 7s
Artifacts 1

pr.yml

on: pull_request
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

6 errors, 24 warnings, and 10 notices
SwiftLint: DuckDuckGo/MaliciousSiteProtection/Settings/MaliciousSiteProtectionSettingsViewModel.swift#L53
Prefer at least one space after slashes for comments (comment_spacing)
Unit Tests
Recorded an issue (MaliciousSiteProtectionSettingsViewModelTests.swift:60:9: Expectation failed: !(result → <not evaluated>))
Unit Tests
"Malicious Site Protection Settings Section should not be shown" (0.006 seconds) 1 issue(s)
Unit Tests
Suite "Malicious Site Protection - Settings View Model Unit Tests" failed after 0.015 seconds with 1 issue(s)
Unit Tests
Test run with 76 tests failed after 4.525 seconds with 1 issue(s)
Unit Tests
Process completed with exit code 65.
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L102
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L148
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L178
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build
xcbeautify 2.16.0 is already installed and up-to-date. To reinstall 2.16.0, run: brew reinstall xcbeautify
Unit Tests
xcbeautify 2.16.0 is already installed and up-to-date. To reinstall 2.16.0, run: brew reinstall xcbeautify
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L102
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L148
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/StatisticsLoader.swift#L178
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Unit Tests: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
Unit Tests: DuckDuckGo/FavoritesDisplayMode+UserDefaults.swift#L23
extension declares a conformance of imported type 'FavoritesDisplayMode' to imported protocol 'LosslessStringConvertible'; this will not behave correctly if the owners of 'Bookmarks' introduce this conformance in the future
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenCallActionOnOnboardingFinalDialog_ThenDidTapDismissContextualOnboardingActionOnDelegateIsCalled
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewFire_ThenReturnViewOnboardingFireDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasNotShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForFinalSpec_ThenReturnViewOnboardingFinalDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasNotShown_ThenActionCallsDidAcknowledgeContextualOnboardingTrackersDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasShown_ThenActionCallsDidTapDismissContextualOnboardingAction
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_ThenReturnViewOnboardingTrackersDoneDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForVisitWebsiteSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenNavigateToActionIsCalledOnDelegate

Artifacts

Produced during runtime
Name Size
BuildLogs Expired
68.5 MB