Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug menu action to reset Remote Messages on macOS #891

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jul 12, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207797025533577/f
iOS PR: duckduckgo/iOS#3076
macOS PR: duckduckgo/macos-browser#2972
What kind of version bump will this require?: Minor

Description:
This change adds API to reset Remote Messages by deleting all records in the database.

Steps to test this PR:
Make sure that CI is green.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jul 12, 2024
@ayoy ayoy requested a review from samsymons July 12, 2024 16:09
@ayoy ayoy assigned samsymons and unassigned ayoy Jul 12, 2024
@ayoy ayoy marked this pull request as ready for review July 12, 2024 16:10
@ayoy ayoy changed the title Add e debug menu action to reset Remote Messages on macOS Add a debug menu action to reset Remote Messages on macOS Jul 12, 2024
@ayoy ayoy merged commit c9462f5 into main Jul 15, 2024
13 checks passed
@ayoy ayoy deleted the dominik/reset-rmf branch July 15, 2024 04:59
samsymons added a commit that referenced this pull request Jul 19, 2024
* main:
  Remove unused VPN session utilities (#898)
  Add new deprecated Mac remote message attribute. (#903)
  Resetting all state for the VPN will cancel the tunnel and stop the monitors (#900)
  Add support for skipping sending usage pixels for remote messages (#902)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#896)
  Removes the listen port from the wireguard client (#901)
  Be explicit when performing developer redirects (#884)
  C-S-S cross origin fixes
  Update C-S-S version (#892)
  Add a debug menu action to reset Remote Messages on macOS (#891)
  Add desktop specific RMF attributes (#883)
  Upload exception message to Sentry (#856)
  Add locale to broken site report (#889)
  Add new subfeature for duckplayer (#885)
  Swiftlint refactoring (#882)
  Remote Messaging Framework for macOS (#876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants