Add pixels for our main VPN funnels #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
force-pushed
the
diego/vpn-controller-pixels
branch
from
1aa89c9 to
2216252
Compare
samsymons
reviewed
Mar 7, 2024
| @@ -480,6 +494,12 @@ open class PacketTunnelProvider: NEPacketTunnelProvider { | |||
|
|
|||
| open override func startTunnel(options: [String: NSObject]?, completionHandler: @escaping (Error?) -> Void) { | |||
| Task { @MainActor in | |||
| os_log("🚀 Options are: %{public}@", String(reflecting: options)) | |||
| os_log("🚀 Error 1: %{public}@", String((TunnelError.startingTunnelWithoutAuthToken as NSError).code)) | |||
| os_log("🚀 Error 2: %{public}@", String((TunnelError.couldNotGenerateTunnelConfiguration(internalError: NSError(domain: "asd", code: 0)) as NSError).code)) | |||
There was a problem hiding this comment.
Should we use a proper domain here?
There was a problem hiding this comment.
I'll kill these.
samsymons
approved these changes
Mar 7, 2024
diegoreymendez
changed the base branch from
release/114.1.0-1
to
hotfix/114.1.0-1
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f macOS PR: duckduckgo/macos-browser#2304 BSK PR: duckduckgo/BrowserServicesKit#698 ## Description Add pixels to better track all main VPN funnels: - VPN Controller Start - VPN Tunnel Start - VPN Tunnel Update (change location, etc)
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f iOS PR: duckduckgo/iOS#2543 BSK PR: duckduckgo/BrowserServicesKit#698 ## Description Add pixels to better track all main VPN funnels: - VPN Controller Start (installation, onboarding) - VPN Tunnel Start - VPN Tunnel Update (change location, etc)
samsymons
added a commit
that referenced
this pull request
Mar 8, 2024
* main: Changes to 114.1.0-1 hotfix branch (#706) Navigation: Improve same-document navigation handling (#702) Add pixels for our main VPN funnels (#698) Remove Autoconsent subfeature (#697) #URL macro (#657) Handle expired entitlement in NetP (#692) Remove isSubscriptionEnabled check when attempting to delete NetP token (#701) Remove CGNAT range. (#691) Subscription keychain sharing for access token (#690) Integrate confirm entitlements endpoint (#700) fix bundle name in breakByRaisingSigInt (#699) Adds support for deleting all logins (#672) Bump C-S-S to 5.2.0 (#695) Update xcode-version to 15.2. (#688) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206737255908394/f
macOS PR: duckduckgo/macos-browser#2304
iOS PR: duckduckgo/iOS#2543
Description
Add pixels to better track all main VPN funnels. For BSK this means:
Testing
See platform-specific PRs for testing instructions.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation