Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing issues with tracker surrogate injection #558

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix timing issues with tracker surrogate injection #558

merged 3 commits into from
Nov 14, 2023

Conversation

sammacbeth
Copy link
Contributor

@sammacbeth sammacbeth commented Nov 10, 2023 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205905930000666/f
iOS PR: duckduckgo/iOS#2143
macOS PR: duckduckgo/macos-browser#1830
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL: https://app.asana.com/0/481882893211075/1205883828810956/f
CC: @bwaresiak

Description:
Improves surrogate injection:

  • Removes debounce.
  • Remove checking of non-script elements.
  • Only check mutated elements in the mutation observer.

Steps to test this PR:

  1. Visit https://test.smbco.de/privacy-protections/surrogates/ in macOS or iOS browser.
  2. All tests (except 'Chromium only') should return 'surrogate loaded'

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@sammacbeth sammacbeth self-assigned this Nov 10, 2023
@sammacbeth sammacbeth marked this pull request as ready for review November 10, 2023 08:33
jonathanKingston
jonathanKingston approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@sammacbeth sammacbeth merged commit 94a48a6 into main Nov 14, 2023
5 checks passed
@sammacbeth sammacbeth deleted the sam/surrogates branch November 14, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanKingston jonathanKingston jonathanKingston approved these changes

Assignees

@sammacbeth sammacbeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @jonathanKingston