NetP iOS notifications settings #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2023
samsymons
reviewed
Oct 31, 2023
Sources/NetworkProtection/Storage/NetworkProtectionNotificationsSettingsStore.swift
Outdated
Show resolved
Hide resolved
samsymons
reviewed
Oct 31, 2023
| static let alerts = "com.duckduckgo.notificationSettings.alertsEnabled" | ||
| } | ||
|
|
||
| private static let alertsEnabledKey = "com.duckduckgo.notificationSettings" |
samsymons
approved these changes
Oct 31, 2023
…nsSettingsStore.swift Co-authored-by: Sam Symons <[email protected]>
graeme
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Oct 31, 2023
Task/Issue URL: https://app.asana.com/0/0/1205768725084797/f BSK: duckduckgo/BrowserServicesKit#541 **Description**: These changes are for iOS and doesn’t include any logical changes for macOS. Just creates a some classes that need to be injected and are currently not on macOS. **Steps to test this PR**: 1. CI should be enough but you can try to build this manually as a sanity check. Have a look at the BSK PR first perhaps to get the idea. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
diegoreymendez
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 1, 2023
Task/Issue URL: https://app.asana.com/0/0/1205768725084797/f BSK: duckduckgo/BrowserServicesKit#541 **Description**: These changes are for iOS and doesn’t include any logical changes for macOS. Just creates a some classes that need to be injected and are currently not on macOS. **Steps to test this PR**: 1. CI should be enough but you can try to build this manually as a sanity check. Have a look at the BSK PR first perhaps to get the idea. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Nov 7, 2023
* main: Fix syncing empty favorites folders (#546) Alert user about abnormal app conditions (#539) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#543) NetP iOS notifications settings (#541) Secure vault app group support (#532) Update autofill to 9.0.0 (#537) linting (#542) feat(dashboard): updating feedback form (#533) Improved IPC support (#536) bump C-S-S for duckplayer on big sur (#538) (#540) Append build number to metricKit crash version (#534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1204630981406975/f
iOS PR: duckduckgo/iOS#2112
macOS PR: duckduckgo/macos-browser#1778
What kind of version bump will this require?: Minor
Description:
See iOS PR for proper description.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template