Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert user about abnormal app conditions #539

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Alert user about abnormal app conditions #539

merged 5 commits into from
Nov 4, 2023

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Oct 19, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1204420573063618/f
iOS PR: duckduckgo/iOS#2110
macOS PR: n/a
What kind of version bump will this require?: Patch

Description:

Introduce better handling of critical errors and adjust some EmailManager code to handle errors within.

Steps to test this PR:
Refer to client testing.

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaceklyp jaceklyp merged commit 86e4aba into main Nov 4, 2023
5 checks passed
@jaceklyp jaceklyp deleted the jacek/alerting branch November 4, 2023 12:51
samsymons added a commit that referenced this pull request Nov 7, 2023
* main:
  Fix syncing empty favorites folders (#546)
  Alert user about abnormal app conditions (#539)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#543)
  NetP iOS notifications settings (#541)
  Secure vault app group support (#532)
  Update autofill to 9.0.0 (#537)
  linting (#542)
  feat(dashboard): updating feedback form (#533)
  Improved IPC support (#536)
  bump C-S-S for duckplayer on big sur (#538) (#540)
  Append build number to metricKit crash version (#534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants