Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky tests #1142

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Disable flaky tests #1142

merged 6 commits into from
Dec 19, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Dec 19, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1200194497630846/1209019292147975/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: N/A

Description:

This PR disables a set of flaky navigation tests.

Steps to test this PR:

  1. Check that CI is green

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons changed the title Test PR Disable flaky tests Dec 19, 2024
@samsymons samsymons requested a review from jdjackson December 19, 2024 20:29
jdjackson
jdjackson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jdjackson jdjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdjackson jdjackson merged commit f287e30 into main Dec 19, 2024
8 checks passed
@jdjackson jdjackson deleted the sam/test-pr branch December 19, 2024 20:52
samsymons added a commit that referenced this pull request Dec 19, 2024
@samsymons
Merge branch 'main' into jjackson/crcid-send-receive-support
bcb85ec 
* main:
  Disable flaky tests (#1142)
  Add force old app delegate flag (#1141)
samsymons added a commit that referenced this pull request Dec 19, 2024
@samsymons
Merge branch 'main' into sam/upgrade-to-xcode-16-2
1fbca59 
* main:
  Apple client send and receive support for crash report cohort IDs (CRCIDs) (#1116)
  Disable flaky tests (#1142)
  Add force old app delegate flag (#1141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdjackson jdjackson jdjackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @jdjackson