Fix return type of AsyncDuckDBConnection.prepare
#1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like it is supposed to return `AsyncPreparedStatement<T>` but since the type parameter is not provided it actually returns `AsyncPreparedStatement<any>`, which passes type checking anyway since `any` is compatible with `T`.
carlopi
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it is supposed to return
AsyncPreparedStatement<T>but since the type parameter is not provided it actually returnsAsyncPreparedStatement<any>. That passes type checking anyway sinceanyis compatible withTbut is inconvenient downstream since it doesn't actually use the type parameter.