Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow_stream_result to startPendingQuery #1903

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add allow_stream_result to startPendingQuery #1903

merged 1 commit into from
Oct 29, 2024

Conversation

Y--
Copy link
Contributor

@Y-- Y-- commented Oct 28, 2024

This PR adds a new parameter to startPendingQuery API to be forwarded to DuckDB's PendingQuery

Notes:

  • parameter is optional
  • default value is false to be consistent with Connection and existing behavior

@carlopi carlopi self-requested a review October 28, 2024 14:16
@Y-- Y-- force-pushed the yl/allow-stream-result branch from 9c0eece to c3ef4ec Compare October 28, 2024 14:26
carlopi
carlopi approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!!

@carlopi carlopi merged commit 72a1db2 into duckdb:main Oct 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlopi carlopi carlopi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-- @carlopi