Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing with dbt 1.9.0 #448

Closed
edgarrmondragon opened this issue Oct 1, 2024 · 4 comments
Closed

Start testing with dbt 1.9.0 #448

edgarrmondragon opened this issue Oct 1, 2024 · 4 comments

Comments

@edgarrmondragon
Copy link
Contributor

I do think there are some changes upstream that impact this adapter:

'dict' object has no attribute 'model' 
@edgarrmondragon
Copy link
Contributor Author

I think I've narrowed this down at least to dbt-labs/dbt-core@27b2f96.

@dataders
Copy link

dataders commented Oct 3, 2024

@edgarrmondragon AFAICT, this shouldn't be happening! can you open an issue on dbt-core with dbt logs the full dbt logs/stacktrace? I looked at the failed run of edgarrmondragon/meltano-dogfood#385 but can't see the dbt logs or stacktrace. Thanks!

@jwills
Copy link
Collaborator

jwills commented Oct 4, 2024

Hey, sorry this was our bad-- we are doing some shady stuff in the adapter to get around a limitation of MotherDuck with temporary tables and we violated the contract on the config object that is passed in to pre_model_hook. The problem was fixed in #451 /cc @guenp

@edgarrmondragon
Copy link
Contributor Author

I logged dbt-labs/dbt-core#10822 in case it turns out something on the dbt end. FWIW I believe publishing the adapter API with type annotations would help maintainers make sure they're not deviating from the interface.

@guenp guenp closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants