Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post_model_hook call in data and unit tests #10809

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Oct 2, 2024

Resolves #10822

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@edgarrmondragon edgarrmondragon force-pushed the fix-post-model-hooks-unit-tests branch from c6e44db to 47da473 Compare October 2, 2024 05:55
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (7940ad5) to head (16562c6).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10809      +/-   ##
==========================================
- Coverage   89.22%   89.18%   -0.05%     
==========================================
  Files         183      183              
  Lines       23457    23459       +2     
==========================================
- Hits        20930    20922       -8     
- Misses       2527     2537      +10     
Flag Coverage Δ
integration 86.42% <100.00%> (-0.13%) ⬇️
unit 62.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.09% <0.00%> (-0.01%) ⬇️
Integration Tests 86.42% <100.00%> (-0.13%) ⬇️

@edgarrmondragon edgarrmondragon force-pushed the fix-post-model-hooks-unit-tests branch from 47da473 to 4155bad Compare October 2, 2024 05:58
@edgarrmondragon edgarrmondragon force-pushed the fix-post-model-hooks-unit-tests branch from 4155bad to 16562c6 Compare October 2, 2024 06:02
@edgarrmondragon edgarrmondragon changed the title Fix post_model_hook in data and unit tests Fix post_model_hook call in data and unit tests Oct 2, 2024
@dbeatty10
Copy link
Contributor

See #10822 (comment)

@dbeatty10 dbeatty10 closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Possible breaking change in calling post_model_hook in data and unit tests
2 participants