Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ondsell #53

Closed
wants to merge 2 commits into from
Closed

Conversation

Mazuricio
Copy link

In Ondsel, the Path workbench is called the CAM workbench. I added parameters to find the workbench on Ondsel

@dubstar-04
Copy link
Owner

dubstar-04 commented Jun 7, 2024

Is it worth removing the PATH references and only supporting FreeCAD 1.0 and later?

@Mazuricio
Copy link
Author

Sorry, I didn't understand your question. The changes only find CAM workbench (Ondsel) if it doesn't find Path workbench (Freecad), don't remove any previous support.

in this line:
if workbench == 'PathWorkbench':
I added an "or"
if workbench == 'PathWorkbench' or workbench == 'CAMWorkbench' :
and added these lines:
if pathMenu is None: pathMenu = mw.findChild(QtGui.QMenu, "&CAM")

and "adjust" is a line I had deleted and duplicated the wrong one, and reverted back to the original

(Ondsel is, as described by itself: "Ondsel is built on top of the FreeCAD solid modeling engine to bring commercial features that make FreeCAD more useful to commercial users.")

@dubstar-04
Copy link
Owner

fixed with #57

@dubstar-04 dubstar-04 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants