feat: lint blocking calls #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what you think about this but I add this lint a while back and the idea come from dax. It caught mostly tests which is not that important, but it caught one usage inside cat command, fixing this lint would allow to programmatically stop introducing such things in the codebase again. |
|
Btw on another note I just noticed that the lint name is not in harmony with the others. seems like it should be |
dsherret
approved these changes
Dec 17, 2023
|
Thanks @dsherret maybe if you have time , you can checkout denoland/deno_lint#1199 do you think that the idea there is correct ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.