Change getargspec to getfullargspec for python 3.11 compatibility #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to work -- getfullargspec returns more than four values. |
|
Can confirm patch is working on python 3.11 tested in several different settings. Besides, that Appveyor build with getfullargspec on python 2.7 fails is totally to be expected - getfullargspec is python 3 only. |
|
Just tried 3.11. Yes, you can build it. But: |
|
Ok, to clarify, I use the pushover backend and have not experienced similar issues.1. nov. 2023 17:44 skrev novalis ***@***.***>:
Just tried 3.11. Yes, you can build it. But:
$ ntfy send test
Traceback (most recent call last):
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/backends/default.py", line 20, in notify
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/backends/linux.py", line 15, in notify
ModuleNotFoundError: No module named 'dbus'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/__init__.py", line 53, in notify
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/backends/default.py", line 22, in notify
ntfy.backends.default.DefaultNotifierError: (ModuleNotFoundError("No module named 'dbus'"), <module 'ntfy.backends.linux' from '/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/backends/linux.py'>)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/ve/bin/ntfy", line 33, in <module>
sys.exit(load_entry_point('ntfy==2.7.1', 'console_scripts', 'ntfy')())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/cli.py", line 362, in main
File "/tmp/ve/lib/python3.11/site-packages/ntfy-2.7.1-py3.11.egg/ntfy/__init__.py", line 68, in notify
ValueError: too many values to unpack (expected 4)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
|
Just to clarify: this doesn't work and it shouldn't have been merged. See the docs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #262 by changing getargspec to getfullargspec. Tested and appears to work with 3.10 and 3.11.