-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Clojure's reader macros #35
base: master
Are you sure you want to change the base?
Add support for Clojure's reader macros #35
Conversation
@countvajhula I'm unsure if the Clojure interface file is the best place for Clojure specific functionality? |
And a second question re. process is; would you rather small PRs that focused on say one reader macro or one PR for all of Clojure's reader macros? |
(symex-clojure-comment-reader-macro count))) | ||
|
||
(defun symex-clojure-comment-reader-macro (count) | ||
"Comment symex using clojure's comment reader macro" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little confused by this docstring - maybe it should say "... using clojure's syntax for commenting reader macros"
@dcostaras Probably one PR for all of them (the existing PRs are fine). And yeah the clojure interface file is a good place for it. |
(let ((count (symex--remaining-length))) | ||
(symex-clojure-comment-reader-macro count))) | ||
|
||
(defun symex-clojure-comment-reader-macro (count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see these functions being used anywhere - is the plan for them to be used from symex-comment
and symex-comment-remaining
?
Would love to see some before / after examples to get a sense of what we're going for. Something like what's in the description for this issue. |
Summary of Changes
Clojure has a number of reader macros, some of which have differing syntax to other lisps. This PR adds support for the unique reader macros.
Public Domain Dedication