Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Clojure's reader macros #35

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dcostaras
Copy link
Contributor

Summary of Changes

Clojure has a number of reader macros, some of which have differing syntax to other lisps. This PR adds support for the unique reader macros.

Public Domain Dedication

  • In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

@dcostaras
Copy link
Contributor Author

@countvajhula I'm unsure if the Clojure interface file is the best place for Clojure specific functionality?

@dcostaras
Copy link
Contributor Author

And a second question re. process is; would you rather small PRs that focused on say one reader macro or one PR for all of Clojure's reader macros?

(symex-clojure-comment-reader-macro count)))

(defun symex-clojure-comment-reader-macro (count)
"Comment symex using clojure's comment reader macro"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little confused by this docstring - maybe it should say "... using clojure's syntax for commenting reader macros"

@countvajhula
Copy link
Collaborator

@dcostaras Probably one PR for all of them (the existing PRs are fine). And yeah the clojure interface file is a good place for it.

(let ((count (symex--remaining-length)))
(symex-clojure-comment-reader-macro count)))

(defun symex-clojure-comment-reader-macro (count)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these functions being used anywhere - is the plan for them to be used from symex-comment and symex-comment-remaining?

@countvajhula
Copy link
Collaborator

Would love to see some before / after examples to get a sense of what we're going for. Something like what's in the description for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants