Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add main field to support npm loading #103

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

zalox
Copy link
Contributor

@zalox zalox commented Nov 10, 2016

Addresses #92, with the main field it is possible to use with npm.

@drvic10k
Copy link
Owner

is that enough to pull also the css through npm?

@zalox
Copy link
Contributor Author

zalox commented Dec 5, 2016

Hi, I can load css by require("bootstrap-sortable/Contents/boostrap-sortable.css") if I use a bundler like webpack that can load css through javascript.

Some packages have a "npm.js" file that exports the module correctly with CSS. I'm not familiar with this, but with the main field, we at least make it possible to download the source through package managers like yarn and npm.

@amureki
Copy link

amureki commented Nov 5, 2017

Hi @drvic10k @zalox

As far as I understand, this should be totally enough for proper publishing.
Can we try to publish it?

I am ready to test published version, ping me if you need help with that!

P.S. And thank you for the package! 👍

@drvic10k drvic10k merged commit ff650fd into drvic10k:master Nov 27, 2017
@drvic10k
Copy link
Owner

sorry for the dalay, can you try it please after the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants