-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency twig/twig to v3 #27
base: develop
Are you sure you want to change the base?
Conversation
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: drupal/composer.lock
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1 1
Lines 1 1
=======================================
Misses 1 1 ☔ View full report in Codecov by Sentry. |
d6ff2ab
to
1be2f65
Compare
1be2f65
to
780dbea
Compare
780dbea
to
fe80be1
Compare
fe80be1
to
165f5b9
Compare
165f5b9
to
bc1ebce
Compare
bc1ebce
to
0aaaf08
Compare
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe update to the Changes
Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
822f957
to
87f34f3
Compare
87f34f3
to
7364665
Compare
|
8a57a8e
to
fa14a1a
Compare
fa14a1a
to
f40b3cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- drupal/composer.json (1 hunks)
Additional comments not posted (1)
drupal/composer.json (1)
28-28
: Review the impact of thetwig/twig
version update.The update from
2.15.2
to3.11.0
is a major version change. Ensure that the codebase is compatible with this new version by reviewing the Twig changelog for any breaking changes or new features that might affect template rendering.
f40b3cb
to
106d33a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- drupal/composer.json (1 hunks)
Additional comments not posted (1)
drupal/composer.json (1)
28-28
: Ensure compatibility with the new version oftwig/twig
.The
twig/twig
dependency has been updated from2.15.2
to3.12.0
. This update introduces new features, improvements, and potential breaking changes. Ensure that the application is thoroughly tested and compatible with the new version. Review the changelog for any deprecated features or altered functionalities that may impact the existing codebase.
aa0ecc7
to
e728c54
Compare
2e191c9
to
aeef1f5
Compare
aeef1f5
to
f0ab941
Compare
f0ab941
to
63879d7
Compare
63879d7
to
4452666
Compare
4452666
to
8579dce
Compare
This PR contains the following updates:
2.15.2
->3.17.1
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
twigphp/Twig (twig/twig)
v3.17.1
Compare Source
v3.17.0
Compare Source
ConditionalExpression
andNullCoalesceExpression
(useConditionalTernary
andNullCoalesceBinary
instead)v3.16.0
Compare Source
InlinePrint
Source
instance toTokenStream
null
fromTwigFilter::getSafe()
andTwigFunction::getSafe()
, return[]
insteadv3.15.0
Compare Source
this can be a BC break if you don't use UPPERCASE constant names
plural
andsingular
filters in the String extensionTempNameExpression
in favor ofLocalVariable
NameExpression
in favor ofContextVariable
AssignNameExpression
in favor ofAssignContextVariable
MacroAutoImportNodeVisitor
MethodCallExpression
in favor ofMacroReferenceExpression
_self.xxx
(auto-imported) macrosfoo.bar(some: arg)
)guard
tag that allows to test if some Twig callables are available at compilation time\Closure
)not
unary operator in an expression with*
,/
,//
, or%
without using explicit parentheses to clarify precedence??
binary operator without explicit parentheses~
binary operator in an expression with+
or-
without using parentheses to clarify precedenceAbstractExpression
args to most constructor arguments for classes extendingAbstractExpression
power
expressions with a negative number in parenthesis ((-1) ** 2
)Node
directly. UseEmptyNode
orNodes
instead.Profile::getStartTime()
andProfile::getEndTime()
They were automatically converted to snake-cased before
attribute
function; use the.
notation and wrap the name with parenthesis insteadsandbox
tagdeprecation_info
instead of the other callable options)enum
functionxor
operatorv3.14.2
Compare Source
v3.14.1
Compare Source
They are now checked via the property policy
toString()
under some circumstances on an object even if the
__toString()
method is not allowed by the security policyv3.14.0
Compare Source
Environment::resetGlobals()
Environment::mergeGlobals()
v3.13.0
Compare Source
types
tag (experimental)Twig\Test\NodeTestCase::getTests()
data provider, overrideprovideTests()
instead.Twig\Test\NodeTestCase::getEnvironment()
as final, overridecreateEnvironment()
instead.Twig\Test\NodeTestCase::getVariableGetter()
, callcreateVariableGetter()
instead.Twig\Test\NodeTestCase::getAttributeGetter()
, callcreateAttributeGetter()
instead.Twig\Test\IntegrationTestCase::getFixturesDirectory()
, this method will be abstract in 4.0Twig\Test\IntegrationTestCase::getTests()
andgetLegacyTests()
as finalv3.12.0
Compare Source
extends
anduse
tags are always allowed in a sandboxed template.This behavior will change in 4.0 where these tags will need to be explicitly allowed like any other tag.
spaceless
filterParser
:getBlockStack()
,hasBlock()
,getBlock()
,hasMacro()
,hasTraits()
,getParent()
null
toTwig\Parser::setParent()
Node::__toString()
to include the node tag if setTwig\Node\Node
that take a Node nameBodyNode
instance as the body of aModuleNode
orMacroNode
constructorOptimizerNodeVisitor::OPTIMIZE_TEXT_NODES
use_yield
isfalse
(which is the default)use_yield
isfalse
(as extensions still usingecho
will work as is):
) in addition to equals (=
) to separate argument names and values in named argumentshtml_cva
function (in the HTML extra package)block
andattribute
functionsCallableArgumentsExtractor
classFunctionExpression
,FilterExpression
, andTestExpression
;pass a
TwigFunction
,TwigFilter
, orTestFilter
insteadFunctionExpression
,FilterExpression
, andTestExpression
filter
node ofFilterExpression
enum_cases
functionv3.11.3
Compare Source
v3.11.2
Compare Source
They are now checked via the property policy
toString()
under some circumstances on an object even if the
__toString()
method is not allowed by the security policyv3.11.1
Compare Source
v3.11.0
Compare Source
OptimizerNodeVisitor::OPTIMIZE_RAW_FILTER
Twig\Cache\ChainCache
andTwig\Cache\ReadOnlyFilesystemCache
Node
deprecated
tagConstantExpression
as being@final
find
filterOptimizerNodeVisitor
PrintNode
shuffle
filtersingular
andplural
filters inStringExtension
Twig\Node\Expression\CallExpression::compileArguments()
Twig\ExpressionParser\parseHashExpression()
in favor ofTwig\ExpressionParser::parseMappingExpression()
Twig\ExpressionParser\parseArrayExpression()
in favor ofTwig\ExpressionParser::parseSequenceExpression()
sequence
andmapping
testsTwig\Node\Expression\NameExpression::isSimple()
andTwig\Node\Expression\NameExpression::isSpecial()
v3.10.3
Compare Source
v3.10.2
Compare Source
v3.10.1
Compare Source
v3.10.0
Compare Source
Make
CoreExtension::formatDate
,CoreExtension::convertDate
, andCoreExtension::formatNumber
part of the public APIAdd
needs_charset
option for filters and functionsExtract the escaping logic from the
EscaperExtension
class to a newEscaperRuntime
class.The following methods from
Twig\\Extension\\EscaperExtension
aredeprecated:
setEscaper()
,getEscapers()
,setSafeClasses
,addSafeClasses()
. Use the same methods on theTwig\\Runtime\\EscaperRuntime
class instead.Fix capturing output from extensions that still use echo
Fix a PHP warning in the Lexer on malformed templates
Fix blocks not available under some circumstances
Synchronize source context in templates when setting a Node on a Node
v3.9.3
Compare Source
twig_escape_filter_is_safe
deprecated functionv3.9.2
Compare Source
v3.9.1
Compare Source
$blocks
variable inCaptureNode
v3.9.0
Compare Source
Node implementations that use "echo" or "print" should use "yield" instead;
all Node implementations should be flagged with
#[YieldReady]
once they've been made ready for "yield";the "use_yield" Environment option can be turned on when all nodes have been made
#[YieldReady]
;"yield" will be the only strategy supported in the next major version
v3.8.0
Compare Source
twig_test_iterable
function. Use the nativeis_iterable
instead.v3.7.1
Compare Source
v3.7.0
Compare Source
v3.6.1
Compare Source
v3.6.0
Compare Source
v3.5.1
Compare Source
v3.5.0
Compare Source
constant
if
nodes when outside of a block and with an empty bodyv3.4.3
Compare Source
v3.4.2
Compare Source
v3.4.1
Compare Source
v3.4.0
Compare Source
v3.3.10
Compare Source
v3.3.9
Compare Source
v3.3.8
Compare Source
sort
filter must require a Closure for thearrow
parameterround
convertToHtml
methodv3.3.7
Compare Source
v3.3.6
Compare Source
v3.3.5
Compare Source
v3.3.4
Compare Source
v3.3.3
Compare Source
v3.3.2
Compare Source
v3.3.1
Compare Source
v3.3.0
Compare Source
v3.2.1
Compare Source
v3.1.1
Compare Source
v3.1.0
Compare Source
v3.0.5
Compare Source
v3.0.4
Compare Source
v3.0.3
Compare Source
v3.0.2
Compare Source
v3.0.1
Compare Source
v3.0.0
Compare Source
v2.16.1
Compare Source
v2.16.0
Compare Source
v2.15.6
Compare Source
v2.15.5
Compare Source
v2.15.4
Compare Source
v2.15.3
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.