-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to ignore SSL certificate errors. #115
base: master
Are you sure you want to change the base?
Conversation
returning early.
@j3pic Thanks for re-raising it. On the git stuff: we typically squash before merging to keep the history in master cleaner. So that can make future merges and rebases fail, but you should be able to get away with rebasing on master and skipping the commits from #80, or alternatively creating a new branch from master and then cherry-picking the commit you wanted from #114. The patch looks good to me. I just checked with the powers that be and it looks like the CLA form is working once again. So could you please give that a shot, and then we can accept this patch. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CLA is sorted.
ping. |
I never heard back about that corporate CLA. |
@gianm Ping, any update on this? |
Rebase pls! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get these merged in, changes look great.
Is there a reason why this PR is still unmerged? Not being able to talk to Druid via HTTPS is a pretty serious problem. |
@didip My former employer, Instacart, has just ignored the request for the "CLA" document (which IIRC has something to do with copyright). I was never able to get it signed by someone high enough in the company. Someone probably needs to re-fix this problem from scratch, since I don't work there anymore. |
Indeed pretty sad that this PR hasn't yet been merged. I've used
Thanks for creating this PR in any case! Hope it'll get merged :) |
This is a remake of #114. I had to delete the entire repo, re-fork it, and manually copy the changed file over because of the way that PR #80 was merged.
I have changed the way
ssl_context()
works so that the configuration check happens there instead of in_post()
.