Chore: fix feature specific lint warnings

- move `use` to inside feature gated test function
- use PanicHookInfo instead of deprecated PanicInfo

- Fix: databendlabs#1256

examples/raft-kv-memstore-network-v2/tests/cluster/test_cluster.rs

@@ -1,7 +1,6 @@
 use std::backtrace::Backtrace;
 use std::collections::BTreeMap;
-#[allow(deprecated)] // since nightly 1.82
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::time::Duration;
 
 use openraft::BasicNode;
@@ -13,8 +12,7 @@ use tokio::task;
 use tokio::task::LocalSet;
 use tracing_subscriber::EnvFilter;
 
-#[allow(deprecated)] // PanicInfo deprecated since nightly 1.82
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = format!("{:?}", Backtrace::force_capture());
 
     eprintln!("{}", panic);

examples/raft-kv-memstore-opendal-snapshot-data/tests/cluster/test_cluster.rs

@@ -1,8 +1,7 @@
 use std::backtrace::Backtrace;
 use std::collections::BTreeMap;
 use std::collections::HashMap;
-#[allow(deprecated)] // since nightly 1.82
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::time::Duration;
 
 use openraft::BasicNode;
@@ -14,8 +13,7 @@ use tokio::task;
 use tokio::task::LocalSet;
 use tracing_subscriber::EnvFilter;
 
-#[allow(deprecated)] // PanicInfo deprecated since nightly 1.82
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = format!("{:?}", Backtrace::force_capture());
 
     eprintln!("{}", panic);

examples/raft-kv-memstore-singlethreaded/tests/cluster/test_cluster.rs

@@ -1,8 +1,7 @@
 use std::backtrace::Backtrace;
 use std::collections::BTreeMap;
 use std::collections::BTreeSet;
-#[allow(deprecated)] // since nightly 1.82
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::time::Duration;
 
 use maplit::btreemap;
@@ -22,8 +21,7 @@ use tokio::task;
 use tokio::task::LocalSet;
 use tracing_subscriber::EnvFilter;
 
-#[allow(deprecated)] // PanicInfo deprecated since nightly 1.82
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = format!("{:?}", Backtrace::force_capture());
 
     eprintln!("{}", panic);

examples/raft-kv-memstore/tests/cluster/test_cluster.rs

@@ -1,7 +1,6 @@
 use std::backtrace::Backtrace;
 use std::collections::BTreeMap;
-#[allow(deprecated)] // since nightly 1.82
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::thread;
 use std::time::Duration;
 
@@ -14,8 +13,7 @@ use raft_kv_memstore::store::Request;
 use tokio::runtime::Runtime;
 use tracing_subscriber::EnvFilter;
 
-#[allow(deprecated)] // PanicInfo deprecated since nightly 1.82
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = {
         format!("{:?}", Backtrace::force_capture())
         // #[cfg(feature = "bt")]

examples/raft-kv-rocksdb/tests/cluster/test_cluster.rs

@@ -1,7 +1,6 @@
 use std::backtrace::Backtrace;
 use std::collections::BTreeMap;
-#[allow(deprecated)] // since nightly 1.82
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::thread;
 use std::time::Duration;
 
@@ -14,8 +13,7 @@ use raft_kv_rocksdb::Node;
 use tokio::runtime::Handle;
 use tracing_subscriber::EnvFilter;
 
-#[allow(deprecated)] // PanicInfo deprecated since nightly 1.82
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = { format!("{:?}", Backtrace::force_capture()) };
 
     eprintln!("{}", panic);

openraft/src/core/tick.rs

@@ -156,6 +156,10 @@ where C: RaftTypeConfig
     }
 }
 
+// AsyncRuntime::spawn is `spawn_local` with singlethreaded enabled.
+// It will result in a panic:
+// `spawn_local` called from outside of a `task::LocalSet`.
+#[cfg(not(feature = "singlethreaded"))]
 #[cfg(test)]
 mod tests {
     use std::io::Cursor;
@@ -181,10 +185,6 @@ mod tests {
         type Responder = crate::impls::OneshotResponder<Self>;
     }
 
-    // AsyncRuntime::spawn is `spawn_local` with singlethreaded enabled.
-    // It will result in a panic:
-    // `spawn_local` called from outside of a `task::LocalSet`.
-    #[cfg(not(feature = "singlethreaded"))]
     #[tokio::test]
     async fn test_shutdown() -> anyhow::Result<()> {
         let (tx, mut rx) = TickUTConfig::mpsc_unbounded();

openraft/src/network/snapshot_transport.rs

@@ -314,7 +314,7 @@ pub trait SnapshotTransport<C: RaftTypeConfig> {
     ///
     /// - The receiving state `streaming` is maintained by the caller.
     /// - And it depends on `Raft::begin_receiving_snapshot()` to create a `SnapshotData` for
-    /// receiving data.
+    ///   receiving data.
     ///
     /// Example usage:
     /// ```ignore

openraft/src/network/v2/network.rs

@@ -92,9 +92,9 @@ where C: RaftTypeConfig
     /// [`Raft::handle_transfer_leader()`]: crate::raft::Raft::handle_transfer_leader
     #[since(version = "0.10.0")]
     async fn transfer_leader(&mut self, _req: TransferLeaderRequest<C>, _option: RPCOption) -> Result<(), RPCError<C>> {
-        return Err(RPCError::Unreachable(Unreachable::new(&AnyError::error(
+        Err(RPCError::Unreachable(Unreachable::new(&AnyError::error(
             "transfer_leader not implemented",
-        ))));
+        ))))
     }
 
     /// Build a backoff instance if the target node is temporarily(or permanently) unreachable.

openraft/src/vote/leader_id/leader_id_std.rs

@@ -99,12 +99,13 @@ impl<NID: NodeId> CommittedLeaderId<NID> {
 #[cfg(test)]
 #[allow(clippy::nonminimal_bool)]
 mod tests {
-    use crate::CommittedLeaderId;
     use crate::LeaderId;
 
     #[cfg(feature = "serde")]
     #[test]
     fn test_committed_leader_id_serde() -> anyhow::Result<()> {
+        use crate::CommittedLeaderId;
+
         let c = CommittedLeaderId::<u32>::new(5, 10);
         let s = serde_json::to_string(&c)?;
         assert_eq!(r#"5"#, s);

tests/tests/fixtures/mod.rs

@@ -10,7 +10,7 @@ use std::collections::HashMap;
 use std::env;
 use std::fmt;
 use std::future::Future;
-use std::panic::PanicInfo;
+use std::panic::PanicHookInfo;
 use std::sync::atomic::AtomicU64;
 use std::sync::atomic::Ordering;
 use std::sync::Arc;
@@ -142,7 +142,7 @@ pub fn set_panic_hook() {
     }));
 }
 
-pub fn log_panic(panic: &PanicInfo) {
+pub fn log_panic(panic: &PanicHookInfo) {
     let backtrace = {
         #[cfg(feature = "bt")]
         {