Skip to content

Commit

Permalink
Fix missing botocore error when S3 deps not installed (#170)
Browse files Browse the repository at this point in the history
Co-authored-by: Jay Qi <[email protected]>
  • Loading branch information
jayqi and jayqi authored Sep 20, 2021
1 parent 5f97f08 commit 8e4dcaf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
# cloudpathlib Changelog

## v0.6.2 (2021-09-20)

- Fixed error when importing `cloudpathlib` for missing `botocore` dependency when not installed with S3 dependencies. ([PR #168](https://github.com/drivendataorg/cloudpathlib/pull/168))

## v0.6.1 (2021-09-17)

- Fixed absolute documentation URLs to point to the new versioned documentation pages.
- Fixed bug where `no_sign_request` couldn't be used to download files since our code required list permissions to the bucket to do so, which is tracked in issue [#169](https://github.com/drivendataorg/cloudpathlib/issues/169). PR [#168](https://github.com/drivendataorg/cloudpathlib/pull/168).
- Fixed bug where `no_sign_request` couldn't be used to download files since our code required list permissions to the bucket to do so. ([Issue #169](https://github.com/drivendataorg/cloudpathlib/issues/169), [PR #168](https://github.com/drivendataorg/cloudpathlib/pull/168)).

## v0.6.0 (2021-09-07)

Expand Down
2 changes: 1 addition & 1 deletion cloudpathlib/s3/s3client.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from pathlib import Path, PurePosixPath
from typing import Any, Dict, Iterable, Optional, Union

from botocore.exceptions import ClientError

from ..client import Client, register_client_class
from ..cloudpath import implementation_registry
Expand All @@ -12,6 +11,7 @@
from boto3.session import Session
from boto3.s3.transfer import TransferConfig
from botocore.config import Config
from botocore.exceptions import ClientError
import botocore.session
except ModuleNotFoundError:
implementation_registry["s3"].dependencies_loaded = False
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ def load_requirements(path: Path):
"Source Code": "https://github.com/drivendataorg/cloudpathlib",
},
url="https://github.com/drivendataorg/cloudpathlib",
version="0.6.1",
version="0.6.2",
)

0 comments on commit 8e4dcaf

Please sign in to comment.