feat: add support for depth parameter in orderbook query #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordy25519
reviewed
Feb 29, 2024
bmuddha
force-pushed
the
client-orderbook-depth
branch
from
6866359
to
0045bc2
Compare
This commit adds new method to DLOBClient, which allows to request orderbook with a required depth. To handle cases when depth is not provided, default constant can be used, which is set to value of 10. Motivation: currently DLOBClient requests the entirety of orderbook, which contains around 50 levels. Sometimes this can be unecessary, for example if we are only interested in best bid/ask, which is why it can be useful to have an option to control the depth of requested orderbook.
bmuddha
force-pushed
the
client-orderbook-depth
branch
from
0045bc2
to
1a9f135
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new method to DLOBClient, which allows to request orderbook with a required depth. To handle cases when depth is not provided, default constant can be used, which is set to value of 10.
Motivation: currently DLOBClient requests the entirety of orderbook, which contains around 50 levels. Sometimes this can be unecessary, for example if we are only interested in best bid/ask, which is why it can be useful to have an option to control the depth of requested orderbook.
The change shouldn't break anything, except for cases, when more than 10 levels of orderbook are expected.