Fixes/error no members handling

lib/riak/connection.ex

@@ -3,13 +3,21 @@ defmodule Riak.Connection do
   Create a linked process to talk with the riak server on host:port.
   """
   def start_link(host \\ '127.0.0.1', port \\ 8087, args \\ []) do
+    init_seed()
     :riakc_pb_socket.start_link(host, port, args)
   end
 
   @doc """
   Create a process to talk with the riak server on host:port.
   """
   def start(host \\ '127.0.0.1', port \\ 8087, args \\ []) do
+    init_seed()
     :riakc_pb_socket.start(host, port, args)
   end
+
+  defp init_seed do
+    # Let's initialize a seed for pseudo uniform random number - no periodic
+    << a :: 32, b :: 32, c :: 32 >> = :crypto.rand_bytes(12)
+    :random.seed(a, b, c)
+  end
 end

lib/riak/crdt/counter.ex

@@ -12,15 +12,17 @@ defmodule Riak.CRDT.Counter do
   @doc """
   Increment a `counter` on the `amount` defaulting in 1
   """
-  def increment(counter, amount \\ 1) when Record.is_record(counter, :counter) do
+  def increment(counter, amount \\ 1)
+  def increment(counter, amount) when Record.is_record(counter, :counter) do
     :riakc_counter.increment(amount, counter)
   end
   def increment(nil, _), do: {:error, :nil_object}
 
   @doc """
   Decrement a `counter` on the `amount` defaulting in 1
   """
-  def decrement(counter, amount \\ 1) when Record.is_record(counter, :counter) do
+  def decrement(counter, amount \\ 1)
+  def decrement(counter, amount) when Record.is_record(counter, :counter) do
     :riakc_counter.increment(-amount, counter)
   end
   def decrement(nil, _), do: {:error, :nil_object}

lib/riak/pool.ex

@@ -23,16 +23,31 @@ defmodule Riak.Pool do
         end
       end
       def unquote(name)(unquote_splicing(other_args)) do
-        pid = :pooler.take_group_member(:riak)
+        pid = take_group_member(:riak, 500)
         result = unquote(name)(pid, unquote_splicing(other_args))
         :pooler.return_group_member(:riak, pid, :ok)
         result
       end
     end
   end
 
+  def take_group_member(group_name, timeout \\ 100)
+  def take_group_member(_, timeout) when timeout <= 0 do
+    :error_no_members
+  end
+  def take_group_member(group_name, timeout) do
+    case :pooler.take_group_member(group_name) do
+      :error_no_members ->
+        #should probably log a warning / error here so the operator knows something is wrong
+        :timer.sleep(100)
+        take_group_member(group_name, timeout - 100)
+        pid -> pid
+    end
+  end
+
   defp extract_guards({:when, _, [left, right]}), do: {left, extract_or_guards(right)}
   defp extract_guards(else_), do: {else_, []}
   defp extract_or_guards({:when, _, [left, right]}), do: [left|extract_or_guards(right)];
   defp extract_or_guards(term), do: [term]
+
 end