Rename @ArrayContentBased to @Poko.ReadArrayContent
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows support for using this feature with a custom Poko annotation. Change ArrayContentBased to a deprecated typealias for compatibility.
drewhamilton
commented
Dec 13, 2024
| @@ -1,12 +1,12 @@ | |||
| public abstract interface annotation class dev/drewhamilton/poko/ArrayContentBased : java/lang/annotation/Annotation { | |||
There was a problem hiding this comment.
Am I correct that there is no binary compatibility concern here because this is a source-retention annotation?
In other words, an app with dependencies on two libraries each compiled with different Poko versions that both use this feature, won't care about the missing dev.drewhamilton.poko.ArrayContentBased type even if it's used to annotate one of the properties in one of the libraries?
JakeWharton
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this discussion, this aligns with the location and tense of
@Poko.Skipand allows for use of the array content-reading feature with a custom Poko annotation.