Move publishing configuration mostly into the build support plugin #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the reliance on magic properties in favor of code.
This allows the sample project to continue to access them.
drewhamilton
force-pushed
the
drew/publish-via-build-support-plugin
branch
from
c05be74 to
d0d51ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives and finishes #188. Moves all publication settings into the build support plugin except for the group and version. These are currently both needed in
gradle.propertiesso they can be read by both the main project and the sample. The build support plugin now manually reads these fromgradle.propertiesand passes them to the publish plugin.