added DisableToStringGeneration annotation #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewhamilton
reviewed
Sep 6, 2023
There was a problem hiding this comment.
I've been delaying this because the API design potentially clashes with #67. I haven't decided what I want to do yet because other tasks are taking priority.
I commented a summary of the options to #50—please comment there if you have a strong opinion. I also updated that issue with a workaround that can be used in the meantime. But I'll happily revisit this PR when I've decided which approach to take!
poko-annotations/src/commonMain/kotlin/dev/drewhamilton/poko/DisableToStringGeneration.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50 issue
Also added some additional checks to existing test