[#1065] Fixed failing GitHub notifications. #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1361 +/- ##
==========================================
- Coverage 3.19% 3.18% -0.01%
==========================================
Files 41 41
Lines 3038 3046 +8
==========================================
Hits 97 97
- Misses 2941 2949 +8 ☔ View full report in Codecov by Sentry. |
AlexSkrypnyk
commented
Aug 17, 2024
| @@ -92,10 +92,11 @@ tasks: | |||
| DREVOPS_NOTIFY_EVENT=post_deployment \ | |||
| DREVOPS_NOTIFY_PROJECT=$LAGOON_PROJECT \ | |||
| DREVOPS_NOTIFY_ENVIRONMENT_URL=$LAGOON_ROUTE \ | |||
| ./scripts/drevops/notify.sh | |||
| ./scripts/drevops/notify.sh || true | |||
There was a problem hiding this comment.
do not fail the deployment if the notifications fail
AlexSkrypnyk
commented
Aug 17, 2024
| @@ -118,7 +118,7 @@ load _helper.bash | |||
| declare -a STEPS=( | |||
| "Started dispatching notifications." | |||
| "Started GitHub notification for pre_deployment event." | |||
| "@curl -X POST -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json -s https://api.github.com/repos/myorg/myrepo/deployments -d {\"ref\":\"mybranch\", \"environment\": \"PR\", \"auto_merge\": false} # {\"id\": \"${app_id}\", \"othervar\": \"54321\"}" | |||
| "@curl -X POST -H Authorization: token token12345 -H Accept: application/vnd.github.v3+json -s https://api.github.com/repos/myorg/myrepo/deployments -d {\"ref\":\"existingbranch\", \"environment\": \"PR\", \"auto_merge\": false} # {\"id\": \"${app_id}\", \"othervar\": \"54321\"}" | |||
There was a problem hiding this comment.
replacing to use existingbranch and nonexistingbranch
AlexSkrypnyk
added
the
PR: AUTOMERGE
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1065
The root cause was related to the fact that a Git ref was used instead of a branch name for PRs.
From https://docs.github.com/en/rest/deployments/deployments?apiVersion=2022-11-28
The script was using
DREVOPS_NOTIFY_REFinstead ofDREVOPS_NOTIFY_BRANCHfor PRs. This PR fixes that.It also adds 2 more changes:
With the now additionally expanded messages, this should provide enough information