Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#736] Added tests for webhook and docker deployment. #1257

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Apr 5, 2024

closes #736

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added tests for webhook, docker login and docker deployment scripts

@richardgaunt richardgaunt changed the title Add docker deployment unit tests. Add webhook and docker deployment unit tests. Apr 5, 2024
@github-actions github-actions bot temporarily deployed to commit April 5, 2024 01:29 Inactive
unset DREVOPS_DEPLOY_WEBHOOK_RESPONSE_STATUS
run scripts/drevops/deploy-webhook.sh
assert_success
assert_output_not_contains "Missing required value for DREVOPS_DEPLOY_WEBHOOK_METHOD."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently scripts have default values for these two environment variables and so check will currently not fail.

@richardgaunt richardgaunt changed the title Add webhook and docker deployment unit tests. Added webhook and docker deployment unit tests. Apr 5, 2024
@richardgaunt richardgaunt changed the title Added webhook and docker deployment unit tests. #736 Added webhook and docker deployment unit tests. Apr 5, 2024
@richardgaunt
Copy link
Collaborator Author

closes #736
All deployment tests have now mocked up tests.

@richardgaunt richardgaunt added the PR: Needs review Pull request needs a review from assigned developers label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.35%. Comparing base (4c7fbbd) to head (526131c).

Files Patch % Lines
.scaffold/tests/bats/_helper.deployment.bash 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1257      +/-   ##
===========================================
- Coverage    68.43%   68.35%   -0.09%     
===========================================
  Files           50       50              
  Lines         3083     3087       +4     
===========================================
  Hits          2110     2110              
- Misses         973      977       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardgaunt
Thank you for your contribution!

@AlexSkrypnyk AlexSkrypnyk changed the title #736 Added webhook and docker deployment unit tests. [#736] Added tests for webhook and docker deployment. Apr 5, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [#736] Added tests for webhook and docker deployment. [#736] Added tests for webhook and docker deployment. Apr 5, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit fbd8070 into develop Apr 5, 2024
18 of 20 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/add-deployment-tests-2 branch April 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore: Add standalone tests for deployment scripts
2 participants