-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#736] Added tests for webhook
and docker
deployment.
#1257
Conversation
unset DREVOPS_DEPLOY_WEBHOOK_RESPONSE_STATUS | ||
run scripts/drevops/deploy-webhook.sh | ||
assert_success | ||
assert_output_not_contains "Missing required value for DREVOPS_DEPLOY_WEBHOOK_METHOD." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently scripts have default values for these two environment variables and so check will currently not fail.
closes #736 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1257 +/- ##
===========================================
- Coverage 68.43% 68.35% -0.09%
===========================================
Files 50 50
Lines 3083 3087 +4
===========================================
Hits 2110 2110
- Misses 973 977 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardgaunt
Thank you for your contribution!
webhook
and docker
deployment.
closes #736
Checklist before requesting a review
[#123] Verb in past tense with dot at the end.
Changed
section about WHY something was done if this was not a normal implementationChanged