Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#942] Added lagoon wrapper to cmds. #1244

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

richardgaunt
Copy link
Collaborator

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added lagoon function wrapper to bash cmds.

Screenshots

@richardgaunt richardgaunt self-assigned this Mar 25, 2024
@richardgaunt richardgaunt added the PR: Needs review Pull request needs a review from assigned developers label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.81%. Comparing base (29ef4a2) to head (004a1c1).
Report is 3 commits behind head on develop.

Files Patch % Lines
scripts/drevops/deploy-lagoon.sh 46.15% 7 Missing ⚠️
scripts/drevops/task-custom-lagoon.sh 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1244   +/-   ##
========================================
  Coverage    64.81%   64.81%           
========================================
  Files           59       59           
  Lines         3322     3322           
========================================
  Hits          2153     2153           
  Misses        1169     1169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk added PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request and removed PR: Needs review Pull request needs a review from assigned developers labels Mar 26, 2024
@richardgaunt richardgaunt force-pushed the feature/update-lagoon-cmd branch from 64c48d3 to d2ab979 Compare March 27, 2024 02:51
@AlexSkrypnyk AlexSkrypnyk merged commit fe95772 into develop Mar 29, 2024
18 of 19 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/update-lagoon-cmd branch March 29, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants