Skip to content
This repository has been archived by the owner on Oct 15, 2023. It is now read-only.

Feature/add support for fixed geometry #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlexSkrypnyk
Copy link
Member

No description provided.

@AlexSkrypnyk
Copy link
Member Author

This PR cannot be merged straight away as it does not correctly handles top values of the elements within the same fixed container.

More work is required to make a decision how fixed elements within fixed scrollable container should be handled when compared with elements outside of those containers. Options:

Option 1. Try to scroll to each element within each container (including nested containers) and retrieve geometry (this is what this PR does), but it introduces an issue with comparing components within the same scrollable container - because they are scrolled to, they have the same top value.

Option 2. Allow comparison only between elements of the same scrolling fixed container OR between elements outside of fixed container and throw an exception that mixed comparison is not supported.

Option 3: Use approach from Option 1 for non-fixed and fixed comparison, but use Option 2 for components within fixed container, but this introduces the whole new geometry criteria (similar to .position() and .offset() in jQuery).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant