Fix indentation for zookeeper annotations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make running it conditional - either this is running or the Dremio cluster. Controlled via helm value --set DremioAdmin=true Change-Id: Ia6d30bcda29e5ea606f57aa6ac22b65aad8a3a91
Change-Id: Ica602f61421506708689bedb36d0d30c887c8407
Enabling support of uploads to S3 or ADLS via config entries in values.yaml. Change-Id: Ie3233cb7085268ecd6aef010be5f61ad67cefc3a
Change-Id: I3b6746fb8eddeff8c56ae4876453d47bfc30ef9b
Change-Id: I2e3444eccd95cdce7fab18045b43270cbbb07f79
Change-Id: I3534f554ee2168ee88e7ae19380e33696a27f2a3
Change-Id: I83a272457e977ea54dc35812a6d28b68dda666ee
1. Pull in the latest config files 2. Update memory, cpu in values.yaml so that they work with the recommended machine types in the docs Change-Id: I47970acda6fc776171f1970ddacb7e0d78dbff58
Plus change REAME layout and two label changes. Change-Id: Ia5e05f13910db5c03361c6166411704b40bf4a8e
DX-16619: Fix the syntax in values.yaml Statefulsets attribute is updateStrategy and the default for that is RollingUpdate. So, deleting those lines would be sufficient and not loose any functionality. Kubernetes client libraries to v1.14 seems to be more strict than earlier version and throws an error with those lines in there. Dropping the lines works with earlier versions of helm. Change-Id: I727adc50a883a4801e737aec0be6b84788f6f357
Change-Id: Ic0aa8058ffbcd46144e451621312554b72dc4a67
Certbot uses port 80 to handshake with LetsEncrypt to generate SSL certificates. So, port 80 is being opened up by default. Change-Id: I565bd37b6b2657c67751efd1eee2f4cc45be4ba8
Azure VMs do not automatically do reverse DNS lookup of the VM's public ip address. Reverse DNS needs to be specifically enabled. Change-Id: Ie92fe9ca6c6358a3704947f201dae4e209602c66
1. The URL for path.dist values for S3, ADLS are different from pre-3.2.0 and 3.2.0+. Handle it. 2. Add support for Azure Storage v2 for path.dist Change-Id: I7730ed4caac22240e579e41641e720bdedf05ec0
Create a Azure Storage V2 account, create a filesystem and directories in there and configure dremio to use that for accelerator and uploads. Change-Id: Ic1ce87d3ed8f2bfc6ac5a8d822af75f742b61d1e
Change-Id: I17e70a423356849c0d2368648a72241b97d5afeb
The image includes useful cloud tools. See the Dockerfile for the list of tools/clients installed. Change-Id: I6edd554ffc37b353813b8c351a9d505332267930
Change-Id: I90e2515ebc230fa8da5940498516f9ae313a019e
Change-Id: If8b01fcc3b7d71563a07f8115ce0c4ae03bd3f9a
- Additionally fixes deploying multiple instances of the CFT in the same subnet by removing the GroupName and allowing AWS to dynamically generate one since GroupName(s) must be unique in a subnet. Change-Id: I1fb6101528b857a40e09f41aebd11a9843ecb257
- Dremio 4.0.0 or later required. - Adds the concept of an imageTag to expose features that are introduced only in newer versions of Dremio. - Removes the dremioVersion value that needs to be manually set to reference the same version that is used by the image. - Adds optional Cloud Cache support. Dist is split between PDFS and cloud storage. Change-Id: Idccb0acbd82a8f3ed50b249599c0b04e93641406
This reverts commit d199978. Change-Id: If484452e8608f2dbdfa2713ca33bb13b4c92c4f0
- Dremio 4.0.0 or later required. - Adds the concept of an imageTag to expose features that are introduced only in newer versions of Dremio. - Removes the dremioVersion value that needs to be manually set to reference the same version that is used by the image. - Adds optional Cloud Cache support. Dist is split between PDFS and cloud storage. Change-Id: I645c53bb772c0d52362052ef77925c08b30cc494
- Updates the ARM template to use an updated base CentOS image. Change-Id: Id77a3e2bf3918ce1314aba435c66b0830a7a024a
Change-Id: I4ea8b85a712047bcd4f6520da3c1ec5452d8b849
Change-Id: I36a84dd6139030f1860b68c870ee2a7e9743dca3
Change-Id: I7cb9bd86c165bf59654ba2c2a26c173d31e3c01d
- Fixes the context used for extraInitContainers when templating the user provided value. Change-Id: I866716fa636ac6c50971b623f314a6de79fbee69
- Exposed Flight endpoint (default port 32010). - Added TLS configuration support to the Flight endpoint. - Added documentation for Flight. Change-Id: I155543d55e8d78c8b13f244918c5a5f8438d89fe
- Fixes the ability to set annotations/labels on StatefulSets in the Helm chart. Change-Id: Ie21980dbd3b626f434c68c517e7a46a6b16450e5
jacob-cabral
suggested changes
May 22, 2021
There was a problem hiding this comment.
Hello!
I've tested this fix. It works well.
The image above shows multiple executions of the Dremio installation. The first one was trying to do this using the source code from the master branch of the dremio/dremio-cloud-tools repository. As it can be seen, the first fails. The second execution was did after applying the changes proposed by rockpunk. As I said, it works.
Best regards,
Jacob Cabral
slachiewicz
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a podAnnotation to values.yaml, helm fails with error:
This was because indents were off by 2 in the zookeeper StatefulSet spec. Whoever thought templating whitespace-dependent files was a good design choice? =)