Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseDocsGenerate and BaseDocsGenReferences Tests #52

Merged
merged 12 commits into from
Nov 3, 2022

Conversation

ravjotbrar
Copy link
Contributor

Summary

Added these tests as part of the requirements for upgrading to dbt-core 1.2.

Description

BaseDocsGenerate

  • Modify second_model.sql to explicitly use alternate schema
  • Modify models fixture to use our version of second_model.sql
  • Modify verify_catalog from dbt-core to exclude source table verification
  • Modify unique_schema fixture to prepend schema with rav-test folder
  • Modify project_config_update fixture to prevent the seed being created as a view
  • Modify profiles fixture to make root_path the same as schema
  • Modify expected_catalog fixture to accommodate dremio data types
  • Include test_run_and_generate methods so they use our version of verify_catalog

BaseDocsGenReferences

  • Modify project_config_update fixture to allow creating a view for seeds. This is because the ephemeral_summary models looks for the seed under database.schema (which is only used for views).
  • Modify unique_schema, profiles, and expected catalog fixtures for same reasons as above

Utilities

  • Modify base_expected_catalog to look for datalake instead of database
  • Modify expected_references_catalog for the same reason above

Other

  • Relevant imports
  • Remove staging snapshot macro

Related Issue

#43
#36

Additional Reviewers

@jlarue26
@ArgusLi

Copy link
Contributor Author

@ravjotbrar ravjotbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid code duplication

@ravjotbrar ravjotbrar merged commit a373dd9 into main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants