Add unit tests using mocks to Go client #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howareyouman
requested changes
Dec 18, 2024
valterfrancisco-dremio
force-pushed
the
add-mock-tests-to-go-client
branch
from
bf61966 to
1b8fa45
Compare
valterfrancisco-dremio
requested review from
xborder,
cultcargo and
Antropovi
cultcargo
reviewed
Dec 20, 2024
cultcargo
reviewed
Dec 20, 2024
cultcargo
reviewed
Dec 23, 2024
cultcargo
reviewed
Dec 24, 2024
valterfrancisco-dremio
force-pushed
the
add-mock-tests-to-go-client
branch
from
3148d08 to
65d1e3f
Compare
cultcargo
reviewed
Dec 26, 2024
cultcargo
reviewed
Dec 26, 2024
valterfrancisco-dremio
force-pushed
the
add-mock-tests-to-go-client
branch
from
65d1e3f to
725b002
Compare
howareyouman
approved these changes
Jan 3, 2025
| set -e | ||
|
|
||
| # Define variables | ||
| MOCKGEN_CMD="mockgen -destination=mock_flightclient.go -package=main github.com/apache/arrow-go/v18/arrow/flight Client" |
There was a problem hiding this comment.
Cool. Thanks for doing this! First step for basic automation in the repo!
|
|
||
| assert.Equal(t, tt.expected, strings.TrimSpace(buf.String())) | ||
| }) | ||
| func TestUsernamePassAuth(t *testing.T) { |
There was a problem hiding this comment.
The tests are finally great and readable with mocks, thanks!
| func run(config interfaces.FlightConfig, client flight.Client, | ||
| readerCreator func(flight.FlightService_DoGetClient) (RecordReader, error), | ||
| ) error { | ||
|
|
||
| // Two WLM settings can be provided upon initial authentication with the dremio | ||
| // server flight endpoint: | ||
| // - routing-tag | ||
| // - routing-queue | ||
| ctx := metadata.NewOutgoingContext(context.TODO(), |
There was a problem hiding this comment.
Do we have this somewhere in the docs?
In golang in general the context should be passed outside. For now it's fine to keep it here, but it would be great to add docs link where this is described.
valterfrancisco-dremio
force-pushed
the
add-mock-tests-to-go-client
branch
from
859a810 to
fb3fcaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the Go Client code to use interfaces to improve modularity and to allow for more meaningful testing.
Changes: