Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule #866

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[Backport] 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule #866

merged 1 commit into from
Sep 27, 2024

Conversation

sendaoYan
Copy link
Collaborator

@sendaoYan sendaoYan commented Sep 24, 2024 •
edited
Loading

Summary: backport JDK-8301313 to fix native build Internal Error matcher.cpp:1632 assert(false) failed: bad AD file

Testing: CI pipeline

Reviewers: MaxXSoft, kuaiwei

Issue: #865

Additional testing:

  • linux riscv64 release/slowdebug native build
  • linux riscv64 jtreg tests(include tier1/2/3 etc.) with release build, the test result shows that all the 10 test falures are environment issue.

@DingliZhang @sendaoYan
[Backport] 8301313: RISC-V: C2: assert(false) failed: bad AD file due…
da86b09 
… to missing match rule

Summary: backport JDK-8301313 to fix native build Internal Error matcher.cpp:1632 assert(false) failed: bad AD file

Testing: CI pipeline

Reviewers: MaxXSoft, kuaiwei

Issue: dragonwell-project#865
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sendaoYan
Copy link
Collaborator Author

make.log.zip

kuaiwei
kuaiwei approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@kuaiwei kuaiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sendaoYan sendaoYan requested a review from MaxXSoft September 27, 2024 07:15
MaxXSoft
MaxXSoft approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@MaxXSoft MaxXSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sendaoYan
Copy link
Collaborator Author

Thanks all for the review.

@sendaoYan sendaoYan merged commit 1abee10 into dragonwell-project:master Sep 27, 2024
43 of 44 checks passed
@sendaoYan sendaoYan deleted the issue865 branch September 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxXSoft MaxXSoft MaxXSoft approved these changes

@kuaiwei kuaiwei kuaiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sendaoYan @CLAassistant @kuaiwei @MaxXSoft @DingliZhang