[GC] Add IO related size policy for Parallel GC #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weixlu
added a commit
to weixlu/dragonwell11
that referenced
this pull request
Jul 29, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project#846 CR: dragonwell-project#847
weixlu
force-pushed
the
decrease_heap_policy
branch
from
7fd0e9d to
93dc2e5
Compare
mmyxym
reviewed
Jul 30, 2024
weixlu
force-pushed
the
decrease_heap_policy
branch
from
93dc2e5 to
55132e3
Compare
weixlu
added a commit
to weixlu/dragonwell11
that referenced
this pull request
Jul 30, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project#846 CR: dragonwell-project#847
weixlu
force-pushed
the
decrease_heap_policy
branch
from
55132e3 to
52efa83
Compare
weixlu
added a commit
to dragonwell-project/dragonwell8
that referenced
this pull request
Jul 30, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project/dragonwell11#846 CR: dragonwell-project/dragonwell11#847
weixlu
added a commit
to dragonwell-project/dragonwell8
that referenced
this pull request
Jul 30, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project/dragonwell11#846 CR: dragonwell-project/dragonwell11#847
linade
reviewed
Jul 31, 2024
|
|
||
| static bool should_update_eden_stats(GCCause::Cause cause) { | ||
| return AdaptiveSizePolicy::should_update_eden_stats(cause) || | ||
| (UseIOPrioritySizePolicy && GCCause::_gc_locker == cause); |
There was a problem hiding this comment.
comment explaining why (cause == _gc_locker) is checked here?
There was a problem hiding this comment.
When running spark on TPC-DS, we observed IO occurs simultaneously with jni calls. So we intend to update eden size upon GC locker caused young gc.
After IO finish, we will restore _throughput_goal to its original value (like 0.99), and typically this goal won't be satisfied. As a result, Adaptive Size Policy will try to increase the heap by 20% each time. |
weixlu
added a commit
to weixlu/dragonwell11
that referenced
this pull request
Jul 31, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project#846 CR: dragonwell-project#847
weixlu
force-pushed
the
decrease_heap_policy
branch
from
52efa83 to
3b0ee54
Compare
linade
reviewed
Jul 31, 2024
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high. Testing: jtreg Reviewers: maoliang.ml, yude.lyd Issue: dragonwell-project#846 CR: dragonwell-project#847
weixlu
force-pushed
the
decrease_heap_policy
branch
from
3b0ee54 to
70a4662
Compare
linade
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high.
Testing: jtreg
Reviewers: maoliang.ml, yude.lyd
Issue: #846
CR: #847