Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Delete extra file .globalDefinitions.hpp.swp #834

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sendaoYan
Copy link
Collaborator

Summary: Delete extra file src/hotspot/share/utilities/.globalDefinitions.hpp.swp

Testing: CI pipeline

Reviewers: kuaiwei.kw, xingqizheng.xqz

Issue: #833

Summary: Delete extra file src/hotspot/share/utilities/.globalDefinitions.hpp.swp

Testing: CI pipeline

Reviewers: kuaiwei.kw, xingqizheng.xqz

Issue: dragonwell-project#833
@sendaoYan sendaoYan requested review from kuaiwei and MaxXSoft June 2, 2024 11:57
@sendaoYan sendaoYan self-assigned this Jun 2, 2024
Copy link
Collaborator

@MaxXSoft MaxXSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kuaiwei kuaiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuaiwei
Copy link
Collaborator

kuaiwei commented Jun 3, 2024

Could we add swp file type into gitignore?

@sendaoYan
Copy link
Collaborator Author

Could we add swp file type into gitignore?

Okey, I will create a new PR.

@sendaoYan sendaoYan merged commit b7e490b into dragonwell-project:master Jun 3, 2024
44 checks passed
@sendaoYan sendaoYan deleted the issue833 branch June 3, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants