[Backport] 8307352: AARCH64: Improve itable_stub #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Improve performance of itable stub on aarch64 Testing: hotspot/jtreg Reviewed-by: kuaiwei, sandlerwang Issue: dragonwell-project#763
|
Code size grows by approximately 20 bytes So I increased this estimate @mmyxym : |
sandlerwang
approved these changes
Jan 8, 2024
kuaiwei
approved these changes
Jan 8, 2024
mmyxym
reviewed
Jan 8, 2024
|
|
||
| // Reduce "estimate" such that "padding" does not drop below 8. | ||
| const ptrdiff_t estimate = UseCompactObjectHeaders ? 128 : 124; | ||
| const ptrdiff_t codesize = typecheckSize + lookupSize; | ||
| const ptrdiff_t estimate = UseCompactObjectHeaders ? 148 : 144; |
There was a problem hiding this comment.
The patch looks good and the estimate size number needs more testing.
mmyxym
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor conflicts:
1 conflict in src/hotspot/cpu/aarch64/assembler_aarch64.hpp:
tip: guarantee(ext().shift() <= 0 || ext().shift() == (int)size, "bad shift");
dw11: guarantee(_ext.shift() <= 0 || _ext.shift() == (int)size, "bad shift");
3 conflicts in src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp similar to:
tip: int ioffset = in_bytes(itableOffsetEntry::interface_offset());
dw11: int ioffset = itableOffsetEntry::interface_offset_in_bytes();
Summary: Improve performance of itable stub on aarch64
Test Plan: hotspot/jtreg
Reviewed-by: kuaiwei, sandlerwang
Issue: #763