Skip to content

Commit

Permalink
Merge branch 'commaai:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
rav4kumar authored May 4, 2024
2 parents bdb09f7 + 84af7ef commit 99ef4e1
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/repo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
pre-commit-autoupdate:
name: pre-commit autoupdate
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
container:
image: ghcr.io/commaai/cereal:latest
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
jobs:
build:
name: build
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Build docker image
Expand All @@ -27,7 +27,7 @@ jobs:
unit_tests:
name: unit tests
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
flags: ['', '--asan', '--ubsan']
Expand All @@ -51,7 +51,7 @@ jobs:
static_analysis:
name: static analysis
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Build docker image
Expand Down
16 changes: 6 additions & 10 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:20.04
FROM ubuntu:24.04

ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
Expand All @@ -12,6 +12,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
git \
libbz2-dev \
libcapnp-dev \
libclang-rt-dev \
libffi-dev \
liblzma-dev \
libncurses5-dev \
Expand All @@ -26,25 +27,20 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
cmake \
ocl-icd-opencl-dev \
opencl-headers \
python-openssl \
python3-dev \
python3-pip \
tk-dev \
wget \
xz-utils \
zlib1g-dev \
&& rm -rf /var/lib/apt/lists/*

RUN curl -L https://github.com/pyenv/pyenv-installer/raw/master/bin/pyenv-installer | bash
ENV PATH="/root/.pyenv/bin:/root/.pyenv/shims:${PATH}"
RUN pyenv install 3.11.4 && \
pyenv global 3.11.4 && \
pyenv rehash && \
pip3 install --no-cache-dir pyyaml Cython scons pycapnp pre-commit ruff parameterized coverage numpy
RUN pip3 install --break-system-packages --no-cache-dir pyyaml Cython scons pycapnp pre-commit ruff parameterized coverage numpy

WORKDIR /project/
RUN cd /tmp/ && \
git clone https://github.com/catchorg/Catch2.git && \
git clone -b v2.x --depth 1 https://github.com/catchorg/Catch2.git && \
cd Catch2 && \
git checkout 229cc4823c8cbe67366da8179efc6089dd3893e9 && \
mv single_include/catch2/ /project/ && \
cd .. \
rm -rf Catch2
Expand Down
1 change: 1 addition & 0 deletions SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ env = Environment(
"-Wunused",
"-Werror",
"-Wshadow",
"-Wno-vla-cxx-extension",
] + ccflags,
LDFLAGS=ldflags,
LINKFLAGS=ldflags,
Expand Down
2 changes: 1 addition & 1 deletion car.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ struct CarEvent @0x9b1657f34caf3ad3 {
fanMalfunction @91;
cameraMalfunction @92;
cameraFrameRate @110;
gpsMalfunction @94;
processNotRunning @95;
dashcamMode @96;
controlsInitializing @98;
Expand Down Expand Up @@ -142,6 +141,7 @@ struct CarEvent @0x9b1657f34caf3ad3 {
noTargetDEPRECATED @25;
brakeUnavailableDEPRECATED @2;
plannerErrorDEPRECATED @32;
gpsMalfunctionDEPRECATED @94;
}
}

Expand Down
5 changes: 5 additions & 0 deletions messaging/tests/test_messaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ def test_receive_timeout(self):
class TestMessaging(unittest.TestCase):

def setUp(self):
# TODO: ZMQ tests are too slow; all sleeps will need to be
# replaced with logic to block on the necessary condition
if "ZMQ" in os.environ:
raise unittest.SkipTest

# ZMQ pub socket takes too long to die
# sleep to prevent multiple publishers error between tests
zmq_sleep()
Expand Down

0 comments on commit 99ef4e1

Please sign in to comment.