Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: upgrade to 1.75.0 #1634

Merged
merged 2 commits into from
Oct 16, 2024
Merged

rust: upgrade to 1.75.0 #1634

merged 2 commits into from
Oct 16, 2024

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

  1. reduce the binary size.
  2. use more rust-clippy lints.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

1. reduce the binary size.
2. use more rust-clippy lints.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high requested a review from a team as a code owner October 15, 2024 14:34
@Desiki-high Desiki-high requested review from imeoer, jiangliu and gaius-qi and removed request for a team October 15, 2024 14:34
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.70%. Comparing base (7c49849) to head (4368a29).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/bin/nydus-image/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage   61.24%   60.70%   -0.54%     
==========================================
  Files         146      146              
  Lines       48189    48355     +166     
  Branches    46156    46322     +166     
==========================================
- Hits        29513    29355     -158     
- Misses      17115    17232     +117     
- Partials     1561     1768     +207     
Files with missing lines Coverage Δ
src/bin/nydus-image/deduplicate.rs 70.22% <100.00%> (-0.14%) ⬇️
utils/src/digest.rs 88.32% <100.00%> (ø)
src/bin/nydus-image/main.rs 0.62% <0.00%> (-0.01%) ⬇️

... and 77 files with indirect coverage changes

@Desiki-high Desiki-high requested a review from a team as a code owner October 15, 2024 15:39
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will retry the CI.

@imeoer imeoer merged commit 4702539 into dragonflyoss:master Oct 16, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants