Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Helm chart): Add env vars into pods #4196

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feat(Helm chart): Add env vars into pods #4196

wants to merge 8 commits into from
+259 −1

Conversation

andreibe24
Copy link

The current change is required to allow use of S3 bucket backups.

@chakaz
Copy link
Collaborator

chakaz commented Nov 26, 2024

@Pothulapati would it be at all possible for you to take a look? 🙏

Pothulapati
Pothulapati requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly loooks right.

Can you add a example/test-case in a new values file under the /contrib/charts/dragonfly/ci', run go test ./... --update` and make sure the output is what we expect and won't break with other changes in the future?

Thanks

@andreibe24
Copy link
Author

Hi @Pothulapati,
I've posted the CI helm tests.

Yours,
Andrei B

@andreibe24
fix: rerun go test
e09575b 
Signed-off-by: andreibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Awaiting requested review from Pothulapati

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibe24 @chakaz @Pothulapati