Skip to content

Commit

Permalink
Bug fix and version bump
Browse files Browse the repository at this point in the history
  • Loading branch information
drachels committed Oct 10, 2023
1 parent 8f5981d commit fe1561d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 2 additions & 0 deletions mod_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ public function add_completion_rules() {
$completionpostgroup = 'completionpostgroup'.$suffix;
$completionpostenabled = 'completionpostenabled'.$suffix;
$completionpostel = 'completionpost'.$suffix;

$group = [];
$group[] = $mform->createElement('checkbox', $completionpostenabled, '', get_string('completionpost', 'hotquestion'));
$group[] = $mform->createElement('text', $completionpostel, '', ['size' => 3]);
Expand All @@ -281,6 +282,7 @@ public function add_completion_rules() {
$completionvotegroup = 'completionvotegroup'.$suffix;
$completionvoteenabled = 'completionvoteenabled'.$suffix;
$completionvoteel = 'completionvote'.$suffix;

$group = [];
$group[] = $mform->createElement('checkbox', $completionvoteenabled, '', get_string('completionvote', 'hotquestion'));
$group[] = $mform->createElement('text', $completionvoteel, '', ['size' => 3]);
Expand Down
5 changes: 4 additions & 1 deletion upgrade.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,17 @@ This files describes changes in the Hot Question code.
20220821 HotQuestion_911 - Need to see about including grades in the Export tool.
20230120 HotQuestion_995 - The grade table needs more info included in the download.

=== 4.1.8 === 2023100900
=== 4.1.8 === 2023101000
20230926 HotQuestion_1076 - Need to implement suffix on mod_for.php for Moodle 4.3.
Added needed code to the mod_form.php file for both add_completion_rules and for
completion_rule_enabled.
20231008 HotQuestion_1091 - Latest codechecker says "Import statements must not begin
with a leading backslash".
20231008 HotQuestion_1092 - Latest codechecker requires convert from long array(),
to short array [].
20231010 HotQuestion_1094 - Using v4.1.8 on IONOS moodle311 test site students cannout
vote/unvote. Did find in grades.php line 42 the closing bracket was missing.
Wound up replaceing the two HQ activities and HQ works as expected.

=== 4.1.7 === 2023052500 Only for M3.11 and above.
=== 4.1.7+ ===
Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2023100900; // The current module version (Date: YYYYMMDDXX).
$plugin->version = 2023101000; // The current module version (Date: YYYYMMDDXX).
$plugin->requires = 2021051700; // Requires Moodle 3.11 version.
$plugin->cron = 0; // Period for cron to check this module (secs).
$plugin->component = 'mod_hotquestion';
$plugin->maturity = MATURITY_STABLE;
$plugin->release = "4.1.8 (Build: 2023100900)"; // User-friendly version number.
$plugin->release = "4.1.8 (Build: 2023101000)"; // User-friendly version number.
$plugin->supported = [311, 403];

0 comments on commit fe1561d

Please sign in to comment.