Merge pull request #95 from dkarlovi/patch-1

fix: correctly handle not found data
dpfaffenbauer · Oct 6, 2023 · c0b9047 · c0b9047
2 parents 677f4c4 + b23d46c
commit c0b9047
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ProcessManagerBundle/Model/Executable/Dao.php b/src/ProcessManagerBundle/Model/Executable/Dao.php
@@ -36,7 +36,7 @@ public function getById($id = null)
 
         $data = $this->db->fetchAssociative('SELECT * FROM '.$this->tableName.' WHERE id = ?', [$this->model->getId()]);
 
-        if (!$data["id"]) {
+        if ($data === false) {
             throw new \Exception("Executable with the ID " . $this->model->getId() . " doesn't exists");
         }
 

diff --git a/src/ProcessManagerBundle/Model/Process/Dao.php b/src/ProcessManagerBundle/Model/Process/Dao.php
@@ -36,7 +36,7 @@ public function getById($id = null)
 
         $data = $this->db->fetchAssociative('SELECT * FROM '.$this->tableName.' WHERE id = ?', [$this->model->getId()]);
 
-        if (!$data["id"]) {
+        if ($data === false) {
             throw new \Exception("Process with the ID " . $this->model->getId() . " doesn't exists");
         }