Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Bootstrap Source Build to .NET 9.0.100-preview.7.24380.1 #42469

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Re-Bootstrap Source Build to .NET 9.0.100-preview.7.24380.1 #42469

merged 1 commit into from
Jul 31, 2024

Conversation

dotnet-sb-bot
Copy link
Contributor

@dotnet-sb-bot dotnet-sb-bot commented Jul 30, 2024 •
edited by ellahathaway
Loading

Needed to consume dotnet/runtime#105572. See #42425 (comment) where it was commented that the sdk version source-build was using did not include the fix.

Re-Bootstrap Source Build to .NET 9.0.100-preview.7.24380.1

@dotnet-sb-bot dotnet-sb-bot requested review from a team as code owners July 30, 2024 22:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jul 30, 2024
@ellahathaway ellahathaway changed the base branch from release/9.0.1xx-preview7 to main July 30, 2024 22:46
@ellahathaway ellahathaway requested review from a team and vijayrkn as code owners July 30, 2024 22:46
@ellahathaway ellahathaway changed the base branch from main to release/9.0.1xx-preview7 July 30, 2024 22:46
@ellahathaway ellahathaway removed request for a team and vijayrkn July 30, 2024 22:46
@ellahathaway
Copy link
Member

Closing and reopening to reset CI checks.

@ellahathaway ellahathaway reopened this Jul 30, 2024
@ellahathaway ellahathaway reopened this Jul 30, 2024
@ellahathaway ellahathaway enabled auto-merge (squash) July 30, 2024 23:01
@build-analysis build-analysis bot mentioned this pull request Jul 30, 2024
Open
3 tasks
@ellahathaway ellahathaway mentioned this pull request Jul 30, 2024
Merged
@NikolaMilosavljevic
Copy link
Member

No changes in arcade dependency? Is that expected?

@ellahathaway
Copy link
Member

ellahathaway commented Jul 30, 2024 •
edited
Loading

No changes in arcade dependency? Is that expected?

I had the same thought. The pipeline (internal Microsoft link) shows that the arcade version is update to date with what's in the Version.Details and global.json.

I also checked it manually, and the version in the source-manifest from the associated VMR build is the same as what's resolved in the pipeline: https://dev.azure.com/dnceng/internal/_git/dotnet-dotnet/commit/cc6a3ab06b7e5fe31714b03b6e7363f273c5bb11?path=/src/source-manifest.json

@ellahathaway ellahathaway merged commit 55d27b7 into release/9.0.1xx-preview7 Jul 31, 2024
31 checks passed
@ellahathaway ellahathaway deleted the jul2024-source-build-1722379374 branch July 31, 2024 00:34
@ericstj
Copy link
Member

ericstj commented Jul 31, 2024

Right that doesn't have the fix, but I think we've been without the fix for a couple months and made it by.

@jakobbotsch jakobbotsch mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotnet-sb-bot @ellahathaway @NikolaMilosavljevic @ericstj