Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CMake Flag -W3 as New CMP0092 no Longer Does it Implicitly #97053

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Enable CMake Flag -W3 as New CMP0092 no Longer Does it Implicitly #97053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3fc57d
Add universal `-W3` option to CMakeLists.txt, as the new policy
ivdiazsa Jan 16, 2024
bd1a6a6
Had not noticed there was already a W3 removal in the compilers'
ivdiazsa Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions eng/native/configurecompiler.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,9 +767,6 @@ if (MSVC)
# Compile options for targeting windows

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/nologo>) # Suppress Startup Banner
# /W3 is added by default by CMake, so remove it
string(REPLACE "/W3" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REPLACE "/W3" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")

# [[! Microsoft.Security.SystemsADM.10086 !]] - SDL required warnings
# set default warning level to 4 but allow targets to override it.
Expand Down
Loading