-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dead code in illink targets #85741
Conversation
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsWe reference ILLink as a packagereference that versions with the runtime, so the 8.0 linker is only supported when targeting
|
Maybe we should guard against that? If it isn't supported. What if I have an app that is multi-targeted? |
I added a warning. Some of the test failures look suspect, so maybe this will help us ensure our tests are also using the right TFM. For multi-targeting, publish requires a single TFM, and will restore the ILLink package matching that TFM unless the user has added a PackageReference already. |
e1410d2
to
0c73186
Compare
This matches the behavior of nativeaot
src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
Outdated
Show resolved
Hide resolved
…argets Co-authored-by: Marek Safar <[email protected]>
@vitek-karas @agocke PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
Outdated
Show resolved
Hide resolved
…argets Co-authored-by: Vitek Karas <[email protected]>
We reference ILLink as a packagereference that versions with the runtime, so the 8.0 linker is only supported when targeting
net8.0
, and we can remove the TFM checks. I am assuming that we don't want to support someone adding a PackageReference to an 8.0 linker, while targeting an older TFM, in an attempt to get newer linker bits but with settings that were closer to what we shipped with that TFM.