Make PlatformDetection.IsInHelix lazy #68445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
jkotas
approved these changes
Apr 23, 2022
am11
reviewed
Apr 23, 2022
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Outdated
Show resolved
Hide resolved
…ion.cs Co-authored-by: Adeel Mujahid <[email protected]>
saul
reviewed
Apr 24, 2022
| @@ -23,7 +23,8 @@ public static partial class PlatformDetection | |||
| // do it in a way that failures don't cascade. | |||
| // | |||
|
|
|||
| public static readonly bool IsInHelix = Environment.GetEnvironmentVariables().Keys.Cast<string>().Where(key => key.StartsWith("HELIX")).Any(); | |||
| private static Lazy<bool> s_IsInHelix => new Lazy<bool>(() => Environment.GetEnvironmentVariables().Keys.Cast<string>().Any(key => key.StartsWith("HELIX"))); | |||
There was a problem hiding this comment.
Think you want a field here, i.e. private static Lazy<bool> s_IsInHelix = ...
s_IsInHelix is creating a new Lazy for each invocation of the getter, so there is no caching happening here.
There was a problem hiding this comment.
Good catch. We have the same problem in number of places actually.
#68473 has the fix
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.