Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more diagnostics to intermittently failing assert in JSON #68414

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Add more diagnostics to intermittently failing assert in JSON #68414

merged 1 commit into from
Apr 23, 2022

Conversation

krwq
Copy link
Member

@krwq krwq commented Apr 22, 2022

Contributes to: #67816

@krwq krwq requested a review from eiriktsarpalis April 22, 2022 19:38
@ghost ghost assigned krwq Apr 22, 2022
@ghost
Copy link

ghost commented Apr 22, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to: #67816

Author: krwq
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

danmoseley
danmoseley approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these wont slow the tests down significantly (like the last time around 😄

@krwq
Copy link
Member Author

krwq commented Apr 23, 2022

I'm preemptively using #if DEBUG + if + Debug.Fail for anything producing larger text - lesson learned 😄

@krwq krwq merged commit e99fb18 into dotnet:main Apr 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

Assignees

@krwq krwq

Labels
area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krwq @danmoseley