New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nullability in SetMeasurementEventCallback (fixes #68025) #68071

Merged

tarekgh merged 6 commits into dotnet:main from soroshsabz:dev/68025-null-checks-in-metrics

Apr 15, 2022

Contributor

soroshsabz commented Apr 15, 2022

ITNOA

Resolved #68025

dotnet-issue-labeler bot added the area-System.Diagnostics.Metric label

ghost added the community-contribution label


          Support nullability in SetMeasurementEventCallback (fixes dotnet#68025)

df0e669

soroshsabz mentioned this pull request

Bogus null checks in MeterListener.SetMeasurementEventCallback<T> #68025

Closed

tarekgh reviewed

View reviewed changes

...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MeterListener.cs Outdated Show resolved Hide resolved

Member

tarekgh commented Apr 15, 2022

@soroshsabz could you please add a test too for the null case?

Member

tarekgh commented Apr 15, 2022


          Revert structure for JIT optimization. (see dotnet#68025)

9bde8c0

tarekgh reviewed

View reviewed changes

...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MeterListener.cs Outdated Show resolved Hide resolved

tarekgh reviewed

View reviewed changes

...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MeterListener.cs Show resolved Hide resolved


          Correct issue find in review. (see dotnet#68025)

13631ee

tarekgh reviewed

View reviewed changes

...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MeterListener.cs Outdated Show resolved Hide resolved


          Correct space. (see dotnet#68025)

9a32685

soroshsabz requested a review from tarekgh

April 15, 2022 18:03


          Add unit test for null measurement event callback. (see dotnet#68025)

60255e2

Contributor Author

soroshsabz commented Apr 15, 2022

@soroshsabz could you please add a test too for the null case?

@tarekgh I added unit test for it. :)

tarekgh reviewed

View reviewed changes

src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricsTests.cs Outdated Show resolved Hide resolved


          Change test for considering review comment. (see dotnet#68025)

0cd6e5e

soroshsabz requested a review from tarekgh

April 15, 2022 19:03

tarekgh approved these changes

View reviewed changes

Member

tarekgh left a comment

Thanks @soroshsabz for helping with this fix!

Contributor Author

soroshsabz commented Apr 15, 2022

@tarekgh I think CI failure is not for my PR, it is seem to be for Json

Member

tarekgh commented Apr 15, 2022

I think CI failure is not for my PR, it is seem to be for Json

Right, it is known and unrelated issue to you changes #67761.

tarekgh merged commit 7368836 into dotnet:main

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Diagnostics.Metric community-contribution