Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency) #110092

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency) #110092

merged 4 commits into from
Nov 30, 2024

Conversation

filipnavara
Copy link
Member

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@filipnavara filipnavara mentioned this pull request Nov 22, 2024
Closed
@filipnavara
Copy link
Member Author

https://github.com/apple-oss-distributions/libpthread/blob/c032e0b076700a0a47db75528a282b8d3a06531a/include/pthread/pthread.h#L520-L527

🤦🏿

This was referenced Nov 23, 2024
Open
Open
Open
Open
Open
@filipnavara filipnavara marked this pull request as ready for review November 23, 2024 10:12
@build-analysis build-analysis bot mentioned this pull request Nov 23, 2024
Open
This was referenced Nov 24, 2024
Open
Open
@filipnavara
Copy link
Member Author

@vitek-karas @akoeplinger Any chance someone can review this? It's basically iOS/tvOS/MacCatalyst build change.

janvorli
janvorli approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@filipnavara filipnavara mentioned this pull request Nov 30, 2024
Open
@jkotas
Copy link
Member

jkotas commented Nov 30, 2024

/ba-g windows x86 Release is known issue #110127 that has been fixed since then

@jkotas jkotas merged commit 979d711 into dotnet:main Nov 30, 2024
154 of 156 checks passed
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
@filipnavara @eduardo-vp
Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency) (
a19c55f 
dotnet#110092)

* Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency)

* Apply _DARWIN_C_SOURCE universally for all Apple platforms
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@filipnavara @mikelle-rogers
Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency) (
9946faf 
dotnet#110092)

* Only define _XOPEN_SOURCE in configurecompiler.cmake (for consistency)

* Apply _DARWIN_C_SOURCE universally for all Apple platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvorli janvorli janvorli approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipnavara @jkotas @janvorli